Conversation
… fee This fixes issue #288 where sendmany transactions with 30+ outputs could fail with "Fee estimation failed. Fallbackfee is disabled" error. The root cause was that DEFAULT_FALLBACK_FEE was set to 0 in v8.22.1, while DEFAULT_MIN_RELAY_TX_FEE was increased by 100x (from 0.001 to 0.1 DGB/kb). When fee estimation fails for complex transactions, a fallback fee safety mechanism is needed. This change: - Sets DEFAULT_FALLBACK_FEE to 1000000 (0.01 DGB/kb) - Updates version to 8.22.2 - Adds test cases to ensure fallback fee works properly The chosen fallback fee value provides a balanced middle ground between v7's 0.001 and v8's 0.1 DGB/kb relay fee.
This change: - Updates src/qt/res/icons/digibyte_wallet.png with the latest version number Signed-off-by: GTO90 <gto90@protonmail.com>
This was
linked to
issues
Mar 14, 2025
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
JaredTate
approved these changes
Mar 14, 2025
JaredTate
left a comment
JaredTate
left a comment
There was a problem hiding this comment.
ACK. Great work! Tested this and it definitely fixes the issue we were having with sendmany.
v8.22.1:
This fix:
Its clear smart fee estimator was just not even working, even in the GUI client with v8.22.1:
This version it goes to fall back fee:
ycagel
approved these changes
Mar 15, 2025
Member
ycagel
left a comment
ycagel
left a comment
There was a problem hiding this comment.
cACK. Great work @gto90 and @JaredTate!
This was referenced Mar 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issues #234 and #288 where sendmany transactions with 30+ outputs could fail with "Fee estimation failed. Fallbackfee is disabled" error.
The root cause was that DEFAULT_FALLBACK_FEE was set to 0 in v8.22.1, while DEFAULT_MIN_RELAY_TX_FEE was increased by 100x (from 0.001 to 0.1 DGB/kb). When fee estimation fails for complex transactions, a fallback fee safety mechanism is needed.
This change:
The chosen fallback fee value provides a balanced middle ground between v7's 0.001 and v8's 0.1 DGB/kb relay fee.