Skip to content

Fix cfg target and add unsupported to geolocation #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix cfg target and add unsupported to geolocation #89

wants to merge 1 commit into from

Conversation

dvdmgl
Copy link

@dvdmgl dvdmgl commented Jul 15, 2025

  • fix cfg target in window
  • add unsupported to geolocation

Closes #80

@dvdmgl dvdmgl force-pushed the fix-unsupported branch 2 times, most recently from ef227db to 08048eb Compare July 16, 2025 19:29
@dvdmgl
fix cfg target and add unsupported to geolocation
33f683d 
- fix cfg target in window
- add unsupported to geolocation
- android and ios theme it's not supported by tao

Issue DioxusLabs#80
@dvdmgl dvdmgl force-pushed the fix-unsupported branch from 08048eb to 33f683d Compare July 17, 2025 10:59
@SadCl0wn
Copy link

Why linux theme is written as Unsupported ?
tao seems to support it, and from my experience on KDE Wayland, it works.

@dvdmgl
Copy link
Author

dvdmgl commented Jul 22, 2025

@SadCl0wn that's a good question, I don't know the reason @DogeDark wrote that it didn't support linux 974c88e#diff-fe2fca3729ebd8bbcd8bbfea9d85d21a492a0faf7e965a64860a9fbaa23a0bb4R9, also tried in KDE, while it didn't correctly identified the theme, didn't crash like android.

@DogeDark
Copy link
Contributor

The event is claimed to be unspoorted in Tao here, but it seems that might be incorrect.

@SadCl0wn
Copy link

The initial theme detection (tauri-apps/tao#643) is not yet properly handled.
I haven't tried to detect theme changes, so the ThemeChanged event might be unsupported, but set_theme and following theme calls work.

@dvdmgl
Copy link
Author

dvdmgl commented Jul 22, 2025

@DogeDark it's correct, digging Tao history I found tauri-apps/tao#468 pull request, it does not support theme change event, but window.theme() it's supported, however running the Tao example in:

  • KDE Wayland with Breeze Dark, it's always Initial theme: Light.
  • GNOME Wayland manjaro gnome VM it's always Initial theme: Dark.

Didn't try X11/Windows/OSX.

Anyway the objective of this PR was to fix cfg flags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

window_size example fails to build on linux
3 participants
@dvdmgl @SadCl0wn @DogeDark