Sov 3274 airswap proxy #528
Conversation
There was a problem hiding this comment.
Need to add the deployment script.
Can refer to this https://github.com/DistributedCollective/Sovryn-smart-contracts/tree/development/deployment/deploy
|
|
||
| uint256 public constant POINTS = 1000; | ||
|
|
||
| uint256 public inputFeeInPoints = 0; |
There was a problem hiding this comment.
Probably can just removed the 0 initialization here, since it will use the zero value by default
| uint256 public constant POINTS = 1000; | ||
|
|
||
| uint256 public inputFeeInPoints = 0; | ||
| uint256 public outputFeeInPoints = 0; |
There was a problem hiding this comment.
Probably can just removed the 0 initialization here, since it will use the zero value by default
| uint256 public inputFeeInPoints = 0; | ||
| uint256 public outputFeeInPoints = 0; | ||
|
|
||
| address public feeVaultAddress = address(0); |
There was a problem hiding this comment.
Probably can just removed the 0 initialization here, since it will use the zero value by default
| uint256 public outputFeeInPoints = 0; | ||
|
|
||
| address public feeVaultAddress = address(0); | ||
| address public swapERC20Address = address(0); |
There was a problem hiding this comment.
Probably can just removed the 0 initialization here, since it will use the zero value by default
| uint8 v; | ||
| bytes32 r; | ||
| bytes32 s; | ||
| } |
There was a problem hiding this comment.
Can add the constructor for the initialization value of the configs
| bytes32 s; | ||
| } | ||
|
|
||
| uint256 public constant POINTS = 1000; |
There was a problem hiding this comment.
By having the points = 1000, this means the smallest fee that we will have is 0.1%, am i correct?
…oxy' into SOV-3274-airswap-proxy
No description provided.