add check in unit test

DistributedCollective · cwsnt · May 22, 2024 · May 24, 2024 · Jun 6, 2024 · Jun 6, 2024
commit cd3cfe721d63faeb06c079218e51e5e926659262
diff --git a/tests/FeeSharingCollectorTest.js b/tests/FeeSharingCollectorTest.js
@@ -502,8 +502,12 @@ contract("FeeSharingCollector:", (accounts) => {
         });
 
         it("setSovrynDexAddress should only be called once", async () => {
+            expect(await feeSharingCollector.sovrynDexAddress()).to.equal(sovrynDex.address);
             const newSovrynDexAddress = (await MockSovrynDex.new()).address;
-            await expectRevert(feeSharingCollector.setSovrynDexAddress(newSovrynDexAddress), "FeeSharingCollector: function can only be called once");
+            await expectRevert(
+                feeSharingCollector.setSovrynDexAddress(newSovrynDexAddress),
+                "FeeSharingCollector: function can only be called once"
+            );
         });
     });
 

diff --git a/contracts/connectors/loantoken/AdvancedToken.sol b/contracts/connectors/loantoken/AdvancedToken.sol
 * Licensed under the Apache License, Version 2.0.
 */

 pragma solidity 0.5.17;

 import "./AdvancedTokenStorage.sol";

 /**
 * @title Advanced Token contract.
        uint256 _assetAmount,
        uint256 _price
    ) internal returns (uint256) {
        require(_to != address(0), "15");

        uint256 _balance = balances[_to].add(_tokenAmount);
        balances[_to] = _balance;
diff --git a/contracts/connectors/loantoken/AdvancedTokenStorage.sol b/contracts/connectors/loantoken/AdvancedTokenStorage.sol
 * Licensed under the Apache License, Version 2.0.
 */

 pragma solidity 0.5.17;

 import "./LoanTokenBase.sol";

 /**
 * @title Advanced Token Storage contract.

    /* Storage */

    mapping(address => uint256) internal balances;
    mapping(address => mapping(address => uint256)) internal allowed;
    uint256 internal totalSupply_;

    /* Functions */

diff --git a/contracts/connectors/loantoken/interfaces/FeedsLike.sol b/contracts/connectors/loantoken/interfaces/FeedsLike.sol
 * Licensed under the Apache License, Version 2.0.
 */

 pragma solidity 0.5.17;

 interface FeedsLike {
    function queryRate(
diff --git a/contracts/connectors/loantoken/interfaces/ProtocolLike.sol b/contracts/connectors/loantoken/interfaces/ProtocolLike.sol
 * Licensed under the Apache License, Version 2.0.
 */

 pragma solidity 0.5.17;
 pragma experimental ABIEncoderV2;

 import "../lib/MarginTradeStructHelpers.sol";
	* Licensed under the Apache License, Version 2.0.
	*/

	pragma solidity 0.5.17;
Check warning on line 6 in contracts/connectors/loantoken/AdvancedToken.sol GitHub Actions / build (18.x) `Compiler version 0.5.17 does not satisfy the ^0.8.0 semver requirement`

	import "./AdvancedTokenStorage.sol";
Check warning on line 8 in contracts/connectors/loantoken/AdvancedToken.sol GitHub Actions / build (18.x) `global import of path ./AdvancedTokenStorage.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)`

	/**
	* @title Advanced Token contract.
	uint256 _assetAmount,
	uint256 _price
	) internal returns (uint256) {
	require(_to != address(0), "15");
Check warning on line 63 in contracts/connectors/loantoken/AdvancedToken.sol GitHub Actions / build (18.x) `Use Custom Errors instead of require statements`

	uint256 _balance = balances[_to].add(_tokenAmount);
	balances[_to] = _balance;