Added python script to count zkSync opcodes on repo #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjcloa
reviewed
Jul 7, 2021
scripts/count_opcodes_zkSync.py
Outdated
|
|
||
| # Opening the JSON output from the last hardhat compilation | ||
| # f = open('artifacts/build-info/eaaf433b5af1a78be582155342f51ab5.json',) | ||
| f = open('artifacts/build-info/0202910f40424d4ba1f4d5c762daecf5.json',) |
There was a problem hiding this comment.
this should not be hardcoded, please use params
and no artifacts/ should be merged
tjcloa
reviewed
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Script to create report on bytecodes not supported by zkSync
DistributedCollective/Sovryn-smart-contracts#285
Requires hardhat compilation of every contract.
Script results:
SOVRYN TOTAL FREQUENCIES:
EXP: 242
ADDMOD: 4
SMOD: 12
MULMOD: 3
CREATE2: 10
SELFDESTRUCT: 6
AMM TOTAL FREQUENCIES:
EXP: 3716
ADDMOD: 3
SMOD: 7
MULMOD: 7
CREATE2: 1
SELFDESTRUCT: 4
In-detail results => https://docs.google.com/spreadsheets/d/1SPeqBk7vRxKlSlvDqKycSRsxFjEGRUj9O-XMr-YMG_8/edit?usp=sharing
As an enhancement it has been researched to use sourcemap to get locations of the opcodes in the contract solidity files, but a big blocker (or a misunderstanding from my part) has been found: To a simple contract example having 100 opcodes is corresponding a sourcemap w/ only 20 semicolons, meaning 21 entries. So the number of codes and map entries differ by much. So it is useless to follow this route in order to trace opcodes to the source with code line accuracy.