Skip to content

Conversation

@jbabac
Copy link

@jbabac jbabac commented Nov 18, 2024

@jbabac jbabac self-assigned this Nov 18, 2024
@jbabac jbabac force-pushed the IDEV-1899-implement-nod-list branch from db99857 to 7c846ca Compare November 18, 2024 17:42
.DS_Store Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be removed, no?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops. this has been removed already.

Copy link

@wesleya wesleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go! Do we need to fix the linting errors?

@jbabac
Copy link
Author

jbabac commented Nov 21, 2024

good to go! Do we need to fix the linting errors?

@wesleya Thank you. yes, I'm still working on it

@jbabac jbabac force-pushed the IDEV-1899-implement-nod-list branch from 7d2d7f1 to e84eb09 Compare November 22, 2024 18:53
Copy link

@briluza briluza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@jbabac jbabac merged commit a8e1828 into 1.5.2 Nov 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants