Skip to content

Conversation

@joshunrau
Copy link
Collaborator

@joshunrau joshunrau commented Dec 4, 2025

This is the cause of David's issue with ODC. By default, Fastify enable cors only enables it for GET, POST, HEAD. For unknown reasons, this seems to cause no issues on Mac. In production, it is not an issue as the site is served from the same origin as api due to reverse proxy setip.

Summary by CodeRabbit

  • Chores
    • Updated cross-origin request handling configuration to support additional HTTP methods and origins.

✏️ Tip: You can customize this high-level summary in your review settings.

@joshunrau joshunrau merged commit 8468b06 into main Dec 4, 2025
0 of 2 checks passed
@coderabbitai
Copy link

coderabbitai bot commented Dec 4, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Modified CORS configuration in configureApp to use explicit options (methods: GET, HEAD, PUT, PATCH, POST, DELETE; origin: '*') instead of the parameterless enableCors() call. Public API signatures and control flow remain unchanged.

Changes

Cohort / File(s) Summary
CORS Configuration Update
src/app/app.utils.ts
Replaced enableCors() with explicit CORS options specifying allowed HTTP methods (GET, HEAD, PUT, PATCH, POST, DELETE) and wildcard origin.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single configuration change with no logic modifications
  • No impact on control flow or public APIs
  • Straightforward CORS policy adjustment

Poem

🌐 CORS now speaks plain, with methods in sight,
Explicit and open, from morning to night,
A wildcard of welcome, for cross-origin flight! ✈️

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cors-linux-dev-fix

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fbe49c8 and 5b0a23e.

📒 Files selected for processing (1)
  • src/app/app.utils.ts (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

🎉 This PR is included in version 8.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants