Update AndroidManifest.xml #1739
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1- I've added <uses-permission android:name="android.permission.INTERNET" /> and other permission that should be in the app, also added activity to launch the app and activity to handle the passport. 2- It's better to generate a new API key for the Google Maps feature instead of using the one provided in the script. This will ensure the security of the application and prevent unauthorized access to the Google Maps feature. 3- The uses-permission and uses-feature elements should be carefully reviewed and only the necessary permissions should be requested. It is important to be transparent with the users about the permissions that the application needs and the reasons why they are necessary. 4- It's better to use android:protectionLevel="signature" for permission that are not critical to the app operation and do not contain sensitive information and if possible, implement runtime permissions which allow users to grant permissions at the time the feature is used rather than at the time of installation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1- I've added
<uses-permission android:name="android.permission.INTERNET" />and other permission that should be in the app, also added activity to launch the app and activity to handle the passport.2- It's better to generate a new API key for the Google Maps feature instead of using the one provided in the script. This will ensure the security of the application and prevent unauthorized access to the Google Maps feature.
3- The uses-permission and uses-feature elements should be carefully reviewed and only the necessary permissions should be requested. It is important to be transparent with the users about the permissions that the application needs and the reasons why they are necessary.
4- It's better to use
android:protectionLevel="signature"for permission that are not critical to the app operation and do not contain sensitive information and if possible, implement runtime permissions which allow users to grant permissions at the time the feature is used rather than at the time of installation.