Skip to content

Added sdw prefix to control statement helper macros.#271

Merged
DragonJoker merged 3 commits intodevelopmentfrom
sdw_macro_prefix
May 19, 2025
Merged

Added sdw prefix to control statement helper macros.#271
DragonJoker merged 3 commits intodevelopmentfrom
sdw_macro_prefix

Conversation

@DragonJoker
Copy link
Owner

No description provided.

Also added a way to disable them completely, you just need to define SDW_DISABLE_CTRL_MACROS  before including Writer.hpp
@DragonJoker DragonJoker added this to the 2.9.0 milestone May 19, 2025
@DragonJoker DragonJoker self-assigned this May 19, 2025
@DragonJoker DragonJoker added the enhancement New feature or request label May 19, 2025
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 19, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
119 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
47.0% Duplication on New Code

See analysis details on SonarQube Cloud

@DragonJoker DragonJoker merged commit 3171bce into development May 19, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in ShaderWriter-Writer May 19, 2025
@DragonJoker DragonJoker deleted the sdw_macro_prefix branch May 19, 2025 19:23
@codecov
Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.88%. Comparing base (6378ab1) to head (89624e8).
Report is 3 commits behind head on development.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #271   +/-   ##
============================================
  Coverage        83.88%   83.88%           
============================================
  Files              497      497           
  Lines            58312    58312           
============================================
  Hits             48917    48917           
  Misses            9395     9395           
Files with missing lines Coverage Δ
include/ShaderAST/Expr/Expr.hpp 100.00% <ø> (ø)
include/ShaderAST/Shader.hpp 100.00% <ø> (ø)
include/ShaderAST/ShaderAllocator.hpp 100.00% <ø> (ø)
include/ShaderAST/Type/Type.hpp 100.00% <ø> (ø)
include/ShaderWriter/BaseTypes/NonUniform.hpp 100.00% <ø> (ø)
...clude/ShaderWriter/CompositeTypes/StructHelper.hpp 100.00% <ø> (ø)
include/ShaderWriter/Writer.hpp 100.00% <ø> (ø)
source/CompilerGlsl/compileGlsl.cpp 58.82% <ø> (ø)
source/CompilerHlsl/HlslGenerateStatements.cpp 77.26% <ø> (ø)
source/CompilerHlsl/HlslHelpers.cpp 75.98% <ø> (ø)
... and 13 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6378ab1...89624e8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Development

Successfully merging this pull request may close these issues.

1 participant