Skip to content

Hlsl fixes#286

Merged
DragonJoker merged 6 commits intodevelopmentfrom
hlsl_fixes
Feb 3, 2026
Merged

Hlsl fixes#286
DragonJoker merged 6 commits intodevelopmentfrom
hlsl_fixes

Conversation

@DragonJoker
Copy link
Owner

No description provided.

@DragonJoker DragonJoker added this to the 2.10.0 milestone Feb 3, 2026
@DragonJoker DragonJoker self-assigned this Feb 3, 2026
@DragonJoker DragonJoker added the bug Something isn't working label Feb 3, 2026
@github-project-automation github-project-automation bot moved this to In progress in ShaderWriter-HLSL Feb 3, 2026
@github-project-automation github-project-automation bot moved this to In progress in ShaderWriter-SPIR-V Feb 3, 2026
@github-project-automation github-project-automation bot moved this to In progress in ShaderWriter-AST Feb 3, 2026
@github-project-automation github-project-automation bot moved this to In progress in ShaderWriter-Writer Feb 3, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2026

@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

❌ Patch coverage is 78.04878% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.41%. Comparing base (9d27d87) to head (02fb40f).
⚠️ Report is 6 commits behind head on development.

Files with missing lines Patch % Lines
source/CompilerHlsl/HlslGenerateStatements.cpp 65.38% 9 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #286      +/-   ##
===============================================
- Coverage        86.41%   86.41%   -0.01%     
===============================================
  Files              514      514              
  Lines            59152    59190      +38     
===============================================
+ Hits             51117    51149      +32     
- Misses            8035     8041       +6     
Files with missing lines Coverage Δ
include/ShaderWriter/BaseTypes/ReturnWrapper.inl 100.00% <ø> (ø)
source/CompilerHlsl/HlslAdaptStatements.cpp 86.59% <ø> (ø)
source/CompilerHlsl/HlslIntrinsicConfig.hpp 88.82% <ø> (ø)
source/CompilerHlsl/HlslIntrinsicNames.hpp 86.84% <100.00%> (+1.60%) ⬆️
source/CompilerSpirV/SpirVGenerateStatements.cpp 84.42% <100.00%> (+0.04%) ⬆️
source/ShaderAST/Visitors/SelectEntryPoint.cpp 99.79% <100.00%> (-0.01%) ⬇️
source/CompilerHlsl/HlslGenerateStatements.cpp 77.21% <65.38%> (-0.41%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d27d87...02fb40f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DragonJoker DragonJoker merged commit d8b6c64 into development Feb 3, 2026
9 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in ShaderWriter-SPIR-V Feb 3, 2026
@github-project-automation github-project-automation bot moved this from In progress to Done in ShaderWriter-HLSL Feb 3, 2026
@github-project-automation github-project-automation bot moved this from In progress to Done in ShaderWriter-AST Feb 3, 2026
@github-project-automation github-project-automation bot moved this from In progress to Done in ShaderWriter-Writer Feb 3, 2026
@DragonJoker DragonJoker deleted the hlsl_fixes branch February 3, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant