Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide title when enable the BigFont/BigDisplay in ContributorsScreen #1151

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

kosenda
Copy link
Contributor

@kosenda kosenda commented Sep 10, 2023

Issue

Overview (Required)

  • Using AutoSizableText no longer causes character breaks.

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

When BigFont/BigDisplay is disabled, Before and After are different, but as far as Figma shows, the same Style is applied, so I do not think there is any problem.
https://www.figma.com/file/MbElhCEnjqnuodmvwabh9K/DroidKaigi-2023-App-UI?type=design&node-id=55032-59308&mode=dev

Settings Before After

@kosenda kosenda changed the title Bug fix/contributors screen use autosizabletext Hide title when enable the BigFont/BigDisplay in ContributorsScreen Sep 10, 2023
@github-actions
Copy link

github-actions bot commented Sep 10, 2023

Test Results

215 tests   215 ✔️  6m 38s ⏱️
  11 suites      0 💤
  11 files        0

Results for commit 0769262.

♻️ This comment has been updated with latest results.

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 10, 2023 08:40 Inactive
@kosenda kosenda marked this pull request as ready for review September 10, 2023 08:43
@kosenda kosenda requested a review from a team as a code owner September 10, 2023 08:43
@takahirom
Copy link
Member

Could you add screenshot tests for this? Maybe we could break this unexpectedly 🙏

@kosenda kosenda marked this pull request as draft September 10, 2023 11:33
@kosenda
Copy link
Contributor Author

kosenda commented Sep 10, 2023

@takahirom
Sorry, I was not able to make a screenshot 🙇
So, I would like to either raise an issue to add a new test or not close this issue.

Since there was no screenshot test for ContributorsScreen, I first tried to create a ContributorsScreenRobot, but I could not prepare a ContributorsViewModel to test it.
If I set = hiltViewModel() as the default argument for ContributorsViewModel in ContributorsScreen as I do for other screens, I can test ContributorsScreenRobot with ContributorsViewModel in ContributorsScreenRobot, but I gave up because I couldn't get the dependencies right.

@kosenda kosenda marked this pull request as ready for review September 10, 2023 14:00
@github-actions github-actions bot temporarily deployed to deploygate-distribution September 10, 2023 14:40 Inactive
@takahirom
Copy link
Member

takahirom commented Sep 11, 2023

I think you can try to use androidMain { dependencies { implement(libs.xxxx) } } 👀

@kosenda
Copy link
Contributor Author

kosenda commented Sep 11, 2023

Thank you!
I'll try it!

@kosenda kosenda marked this pull request as draft September 11, 2023 01:00
@takahirom
Copy link
Member

Sorry, we should use androidUnitTest like this. Because androidMain will affect the main artifact.

    androidUnitTest {
        dependencies {
            
        }
    }

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 11, 2023 15:17 Inactive
@kosenda
Copy link
Contributor Author

kosenda commented Sep 11, 2023

@takahirom
Sorry for repeating 🙇
I have tried test, but I don't know how to test it at all, so I would like to either create a new issue for testing or not close the issue.

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 11, 2023 15:57 Inactive
@kosenda kosenda marked this pull request as ready for review September 14, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide title when enable the BigFont/BigDisplay in ContributorsScreen
2 participants