-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide title when enable the BigFont/BigDisplay in ContributorsScreen #1151
base: main
Are you sure you want to change the base?
Hide title when enable the BigFont/BigDisplay in ContributorsScreen #1151
Conversation
Could you add screenshot tests for this? Maybe we could break this unexpectedly 🙏 |
@takahirom Since there was no screenshot test for |
I think you can try to use |
Thank you! |
Sorry, we should use androidUnitTest like this. Because androidMain will affect the main artifact.
|
@takahirom |
Issue
Overview (Required)
Links
Screenshot (Optional if screenshot test is present or unrelated to UI)
When BigFont/BigDisplay is disabled, Before and After are different, but as far as Figma shows, the same Style is applied, so I do not think there is any problem.
https://www.figma.com/file/MbElhCEnjqnuodmvwabh9K/DroidKaigi-2023-App-UI?type=design&node-id=55032-59308&mode=dev