Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detekt run configuration for format #1162

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

att55
Copy link
Contributor

@att55 att55 commented Sep 10, 2023

Issue

Overview (Required)

I add Spotless run configuration for format.

As I had asked before, I reinstalled Spotless.
#1034 (comment)

Is what I did correct?

I add a configuration to run detekt.

Screenshot (Optional if screenshot test is present or unrelated to UI)

スクリーンショット 2023-09-12 0 10 57

@att55 att55 requested a review from a team as a code owner September 10, 2023 15:32
@att55 att55 requested a review from upon0426 September 10, 2023 15:32
@github-actions
Copy link

github-actions bot commented Sep 10, 2023

Test Results

215 tests   215 ✔️  8m 53s ⏱️
  11 suites      0 💤
  11 files        0

Results for commit e3a90cd.

♻️ This comment has been updated with latest results.

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 10, 2023 20:08 Inactive
@takahirom
Copy link
Member

We are using detekt like this.
./gradlew detekt --auto-correct
It uses ktlint internally. So we don't have to introduce spotless. 👀

@att55 att55 changed the title Add Spotless run configuration for format Add detekt run configuration for format Sep 11, 2023
@att55
Copy link
Contributor Author

att55 commented Sep 11, 2023

@takahirom
Thank you for your reply!
So, I should have added a configuration file for detekt.

I removed spotless and added a configuration file to run for detekt.
Please check again. 🙏🏼

スクリーンショット 2023-09-12 0 10 57

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 12, 2023 02:54 Inactive
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for adding new mechanism!

@takahirom takahirom merged commit 8c72110 into DroidKaigi:main Sep 12, 2023
8 checks passed
Corvus400 added a commit to Corvus400/conference-app-2023 that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants