Skip to content

fix: manage scouts properly .then()s so allChildren isnt used before init #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dropheart merged 2 commits into from
Jun 18, 2025
Merged

fix: manage scouts properly .then()s so allChildren isnt used before init #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c34be2
fix: manage scouts properly .then()s so allChildren isnt used before …
Dropheart Jun 18, 2025
e4dd197
Merge branch 'main' into fix/single_events_page
Dropheart Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions scouts_finances_flutter/lib/events/event_add_participant.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class _EventAddParticipantState extends State<EventAddParticipant> {

late StreamSubscription stream;

void _getChildren() async {
Future<void> _getChildren() async {
try {
allChildren = await client.scouts.getChildren();
} catch (e) {
Expand All @@ -56,20 +56,22 @@ class _EventAddParticipantState extends State<EventAddParticipant> {
loading--;
}

void refresh() {
void refresh() async {
setState(() {
loading = 2;
err = null;
});
_getChildren();
_getEventChildren();
_getChildren().then((_) {
_getEventChildren();
});
}

@override
void initState() {
super.initState();
_getChildren();
_getEventChildren();
_getChildren().then((_) {
_getEventChildren();
});
stream = client.event.eventStream().listen((_) {
refresh();
});
Expand Down
3 changes: 2 additions & 1 deletion scouts_finances_flutter/lib/events/single_event.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,8 @@ class _SingleEventState extends State<SingleEvent> {
closeFn: () => _getEventDetails(),
),
])),
if (children.isNotEmpty) reminderButton
if (children.isNotEmpty) reminderButton,
const SizedBox(height: 128),
],
),
),
Expand Down
2 changes: 1 addition & 1 deletion scouts_finances_server/lib/src/payments.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ class PaymentEndpoint extends Endpoint {
buffer.writeln('Dear ${parent.firstName},\n');

buffer.writeln(
'Your payment of ${assignablePayments.fold(0, (sum, p) => sum + p.amount).formatMoney} have been recieved and processed successfully.');
'Your payment of ${assignablePayments.fold(0, (sum, p) => sum + p.amount).formatMoney} has been recieved and processed successfully.');
buffer.writeln('Your new financial standing is as follows:');
final financialStanding = await eventRemindersForParent(session, parent);
buffer.writeln(financialStanding);
Expand Down