Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M704 run custom g-code macro #263

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

M704 run custom g-code macro #263

wants to merge 1 commit into from

Conversation

dragonnn
Copy link

add M704 command to run custom macro from current loaded filament
This is a follow to my post https://forum.duet3d.com/topic/8887/run-custom-macro-for-loaded-filament
I deiced I will give a try and implement it. Seems to work fine, even when the file isn't found or no filament is loaded.

add M704 command to run custom macro from current loaded filament
@dc42
Copy link
Collaborator

dc42 commented Feb 23, 2020

Thank you for your contribution. Your PW appears to define a new code M704 which works mostly like M703 except that a custom filament can be chosen instead of config.g. Instead of introducing a new GCode, please can you look at the whether the following alternatives would meet your requirement:

  1. Using conditional GCode to execute a M98 command, where the filename is constructed from the directory of the current filament and the required filename;
  2. Add an optional string parameter for the filename to the M703 command, with the default being config.g. This might not be exactly what you want because the current M703 implementation checks that the filament is loaded too.

abates-dentsu pushed a commit to abates-dentsu/RepRapFirmware that referenced this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants