-
Notifications
You must be signed in to change notification settings - Fork 10
Update EKAT to require C++20 #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Asking the obv question: are we sure that E3SM will build everywhere with C++20 required? If not, this my hold back any ekat update in e3sm. |
|
It will not build with all of our current default compilers. In particular, the "intel" compiler on Chrysalis. Possibly others. |
bartgol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Only possible concern is whether e3sm is ready for c++20 across all machines.
|
@bartgol @rljacob Good to know. I created this PR while I'm testing E3SM on the target machines, but since we already know there will be some that are not compatible, we will need to find a different way to handle this. Kokkos 5 is going to require C++20, what would the process be to eventually update compilers on Chrysalis (and maybe others) so that we can upgrade? Or is this going to be a bigger roadblock? I guess the first step is for me to test exactly which compilers do not work. |
|
One solution would be to mis with a cmake2.0 way of specifying the std, via something like if (NOT CMAKE_CXX_STANDARD)
target_compile_features(ekat_core PUBLIC cxx_std_20)
endif()Then, in the mach files for old compilers we keep lines like which will force ekat to honor the required standard. Of course, for machines where we do set 17 in the mach files, we won't be able to build anything that needs kokkos 5.0 (e.g. any F case, since EAM still use kokkos for the SL transport). This means that we cannot switch to kokkos 5 until we can abandon compilers that only support c++17. |
|
On Chrysalis:
|
Ugh, that's underwhelming. I wonder if this is on the chrys IT folks' radar... |
Yeah, I want to try and make a small reproducer outside of E3SM. Make sure it's not something we are doing. |
5695852 to
9b9729c
Compare
This option was not actually forcing the cxx version when I changed to 20...
9b9729c to
8244207
Compare
Update EKAT to require C++20
Motivation
Needed to update to Kokkos 5.0.
Testing
CI already uses C++20.