Skip to content

Conversation

@smoors
Copy link
Contributor

@smoors smoors commented May 4, 2025

edit: adds 4 chattiness levels:

  • incognito: no comments
  • minimal:
    • respond with a single comment to bot cmds help, show_config, status
    • report build progress and result
  • basic: minimal + report failures
  • chatty: basic + everything else (same as current behavior)

i'm of course open to changes to this proposal.

fixes #290

@trz42
Copy link
Contributor

trz42 commented May 4, 2025

Nice. How about an incognito mode? Just ignores all commenting.

@boegel
Copy link
Contributor

boegel commented May 7, 2025

@smoors Can you sync with develop now that #316 is merged?

@boegel
Copy link
Contributor

boegel commented May 8, 2025

@smoors CI is now failing with a genuine test failure?

@smoors
Copy link
Contributor Author

smoors commented May 8, 2025

@smoors CI is now failing with a genuine test failure?

all green now :)

@trz42
Copy link
Contributor

trz42 commented May 22, 2025

Nice work @smoors ! Not just fixing #290 but also doing some code refactoring. I'll try to run a few tests, but there shouldn't be any surprises.

Copy link
Contributor

@trz42 trz42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with two bot instances, tried different levels and different bot commands. Works as intended. Thanks a lot @smoors !

@trz42 trz42 merged commit f85be5c into EESSI:develop May 22, 2025
4 checks passed
@smoors smoors deleted the chatlevel branch May 22, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add support for 'silent' mode

3 participants