-
Notifications
You must be signed in to change notification settings - Fork 7
added the missing helper file #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🧹 Catalogue's Preview Site CleanupThe preview site for this pull request has been cleaned up. If you need a new preview, please reopen the PR or create a new one. |
HansVRP
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not necessarily need to add this file. APEX per definition does not have to host the creation file
| temporal_extent=date, | ||
| bands=bands) | ||
| s1_grd = s1_grd.sar_backscatter(coefficient='sigma0-ellipsoid') | ||
| s1_grd = s1_grd.rename_labels(dimension="bands", target=bands) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this rename_labels required?
| spatial_extent=polygon, | ||
| temporal_extent=date, | ||
| bands=["SCL"]) | ||
| mask = mask = scl.process("to_scl_dilation_mask", data=scl) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this the old method which got deprecated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also mask = mask = ...
| """ | ||
| base_biopar = process( | ||
| process_id="BIOPAR", | ||
| namespace="https://openeo.dataspace.copernicus.eu/openeo/processes/u:3e24e251-2e9a-438f-90a9-d4500e576574/BIOPAR", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't have an alternative for this?
| :return: | ||
| """ | ||
| collections = None | ||
| for option in [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think its good practice to have these optional patterns in UDP generation. It defeats the purpose of being deterministic
We noticed that a file was missing, likely during the migration process.
Nevertheless, it was already referenced in the process graph, so it does not change the graph.