-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cam6_4_073: New CARMA trop_strat aerosol model #1210
Conversation
…stly r8 and cleanup modified: src/physics/carma/cam/carma_precision_mod.F90 modified: src/physics/carma/models/bc_strat/carma_model_mod.F90 modified: src/physics/carma/models/cirrus/carma_model_mod.F90 modified: src/physics/carma/models/cirrus/growevapl.F90 modified: src/physics/carma/models/cirrus_dust/carma_mod.F90 modified: src/physics/carma/models/cirrus_dust/carma_model_mod.F90 modified: src/physics/carma/models/cirrus_dust/growevapl.F90 modified: src/physics/carma/models/dust/carma_model_mod.F90 modified: src/physics/carma/models/meteor_impact/carma_model_flags_mod.F90 modified: src/physics/carma/models/meteor_impact/carma_model_mod.F90 modified: src/physics/carma/models/meteor_smoke/carma_model_mod.F90 modified: src/physics/carma/models/mixed_sulfate/carma_model_mod.F90 modified: src/physics/carma/models/pmc/carma_model_mod.F90 modified: src/physics/carma/models/pmc_sulfate/carma_model_mod.F90 modified: src/physics/carma/models/sea_salt/carma_model_mod.F90 modified: src/physics/carma/models/sulfate/carma_model_mod.F90 modified: src/physics/carma/models/test_detrain/carma_model_mod.F90 modified: src/physics/carma/models/test_growth/carma_model_mod.F90 modified: src/physics/carma/models/test_passive/carma_model_mod.F90 modified: src/physics/carma/models/test_radiative/carma_model_mod.F90 modified: src/physics/carma/models/test_swelling/carma_model_mod.F90 modified: src/physics/carma/models/test_tracers/carma_model_mod.F90 modified: src/physics/carma/models/test_tracers2/carma_model_mod.F90 modified: src/physics/carma/models/tholin/carma_model_mod.F90 modified: test/system/TR8.sh
modified: cime_config/testdefs/testlist_cam.xml
modified: src/physics/cam/ndrop.F90 modified: src/physics/cam/nucleate_ice.F90 modified: src/physics/cam/physics_types.F90
modified: src/chemistry/aerosol/carma_aerosol_properties_mod.F90 modified: src/chemistry/carma_aero/carma_aero_gasaerexch.F90 modified: src/physics/carma/cam/carma_intr.F90 modified: src/physics/carma/models/trop_strat_soa1/carma_model_mod.F90 modified: src/physics/carma/models/trop_strat_soa5/carma_model_mod.F90
…settings modified: bld/build-namelist modified: src/physics/cam/nucleate_ice_cam.F90
modified: src/chemistry/aerosol/mo_setsox.F90 modified: src/chemistry/bulk_aero/aero_model.F90 modified: src/chemistry/bulk_aero/sox_cldaero_mod.F90 modified: src/chemistry/carma_aero/aero_model.F90 modified: src/chemistry/carma_aero/sox_cldaero_mod.F90 modified: src/chemistry/modal_aero/aero_model.F90 modified: src/chemistry/modal_aero/sox_cldaero_mod.F90 modified: src/physics/spcam/ecpp/ecpp_modal_cloudchem.F90 modified: src/physics/spcam/ecpp/module_ecpp_ppdriver2.F90 modified: src/physics/spcam/ecpp/module_ecpp_td2clm.F90
modified: src/chemistry/geoschem/chemistry.F90
modified: bld/build-namelist modified: bld/namelist_files/namelist_defaults_cam.xml modified: src/physics/cam/nucleate_ice.F90
Draft PR for now. Needs to follow PR #1201. |
modified: src/chemistry/mozart/mo_usrrxt.F90
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still have quite a ways to go, but I am submitting my current review comments so they don't get lost.
modified: bld/namelist_files/namelist_definition.xml
modified: bld/build-namelist
…hysics new file: src/physics/cam/carma_diags_mod.F90 modified: src/physics/cam/physpkg.F90
modified: src/physics/cam/carma_diags_mod.F90 modified: src/physics/cam/physpkg.F90
modified: src/chemistry/aerosol/carma_aerosol_properties_mod.F90
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fvitt! I had a few mostly minor fixes and a couple of clarification questions.
modified: bld/namelist_files/namelist_definition.xml modified: src/chemistry/aerosol/hygrocoreshell_aerosol_optics_mod.F90 modified: src/chemistry/aerosol/hygrowghtpct_aerosol_optics_mod.F90 modified: src/chemistry/carma_aero/aero_model.F90 modified: src/chemistry/carma_aero/sox_cldaero_mod.F90
modified: src/chemistry/aerosol/carma_aerosol_state_mod.F90 modified: src/chemistry/carma_aero/sox_cldaero_mod.F90
modified: src/chemistry/carma_aero/aero_model.F90
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fvitt there are just two other instances of the same issues mentioned in the previous review, everything else looks great!
modified: src/chemistry/aerosol/carma_aerosol_state_mod.F90
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fvitt!
modified: src/physics/cam/microp_aero.F90 modified: src/physics/cam/ndrop_bam.F90
Introduce CARMA trop_strat sectional aerosol model which can be as an alternative to the modal aerosol aerosol representation in CAM physics.
closes #495