-
Notifications
You must be signed in to change notification settings - Fork 165
cam6_4_074: Complete CCPPization of Hack shallow convection #1256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flatten qpert pbuf entry to ncol only This commit is continuously amended to make rebasing easier
nusbaume
requested changes
Mar 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @jimmielin! I just had a few minor change requests.
Co-authored-by: Jesse Nusbaumer <[email protected]>
nusbaume
approved these changes
Mar 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great to me now. Thanks @jimmielin!
gold2718
pushed a commit
to gold2718/CAM
that referenced
this pull request
Apr 14, 2025
Merge pull request ESCOMP#1256 from jimmielin/hplin/hk_conv cam6_4_074: Complete CCPPization of Hack shallow convection ESCOMP commit: acc5271
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of changes (include the issue number and title text for each relevant GitHub issue):
Other changes for CCPPization that resolve issues in atmospheric_physics:
List all existing files that have been modified, and describe the changes: