Skip to content

Conversation

jimmielin
Copy link
Member

Purpose of changes (include the issue number and title text for each relevant GitHub issue):

Other changes for CCPPization that resolve issues in atmospheric_physics:

List all existing files that have been modified, and describe the changes:

M       .gitmodules
M       src/atmos_phys
   - update atmospheric_physics to bring in Hack shallow convection,
     and related CCPPized physics changes.

M       bld/configure
   - add path to atmos_phys/schemes/hack_shallow

M       src/physics/cam/convect_shallow.F90
M       src/physics/cam/hk_conv.F90
   - CCPPize Hack shallow convection.


M       src/physics/cam/vertical_diffusion.F90
M       src/physics/cam/physpkg.F90
M       src/physics/cam7/physpkg.F90
   - removal of unused second dimension (pcnst) of qpert because it is not supported
     in CAM-SIMA snapshot reads.

M       src/physics/cam/macrop_driver.F90
M       src/physics/cam/zm_conv_intr.F90
M       src/physics/cam/rk_stratiform.F90
   - add errmsg, errflg to cloud_fraction_fice CCPPized scheme.

M       src/physics/cam/zm_conv_intr.F90
   - move unit conversion of convective mass fluxes to kg m-2 s-1 to 
     inside CCPPized scheme for consistency with snapshots.

Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @jimmielin! I just had a few minor change requests.

@jimmielin jimmielin requested a review from nusbaume March 3, 2025 22:07
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great to me now. Thanks @jimmielin!

@cacraigucar cacraigucar changed the title Complete CCPPization of Hack shallow convection cam6_4_074: Complete CCPPization of Hack shallow convection Mar 5, 2025
@jimmielin jimmielin merged commit acc5271 into ESCOMP:cam_development Mar 6, 2025
2 checks passed
gold2718 pushed a commit to gold2718/CAM that referenced this pull request Apr 14, 2025
Merge pull request ESCOMP#1256 from jimmielin/hplin/hk_conv

cam6_4_074: Complete CCPPization of Hack shallow convection

ESCOMP commit: acc5271
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Tag
Development

Successfully merging this pull request may close these issues.

2 participants