Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cam6_4_072: Fix broken RRTMGP GPU tests #1260

Merged
merged 3 commits into from
Feb 28, 2025

Conversation

sjsprecious
Copy link
Collaborator

This PR fixes the broken RRTMGP GPU tests reported in #997 . The changes are borrowed from the EarthWorks code base (EarthWorksOrg#25, thanks to John and Supreeth).

I used the cam6_4_064 tag on Derecho and confirmed that running PUMAS+CLUBB+RRTMGP on the NVIDIA A100 GPU now passed the ensemble consistency test.

The CPU tests should be BFB. I updated the GPU tests to enable the RRTMGP GPU code so the results were different from the existing baseline as expected.

@sjsprecious
Copy link
Collaborator Author

fix #997

Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just had one general question on the explicit passing of DDTs as well as the variables they contain.

@cacraigucar cacraigucar changed the title Fix broken RRTMGP GPU tests cam6_4_072: Fix broken RRTMGP GPU tests Feb 27, 2025
@nusbaume nusbaume merged commit 17a0cbd into ESCOMP:cam_development Feb 28, 2025
2 checks passed
@sjsprecious sjsprecious deleted the fix_rrtmgp_gpu branch February 28, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Tag
Development

Successfully merging this pull request may close these issues.

2 participants