part of cam6_4_075: Implement parcel_hscale as a namelist parameter in ZM deep convection scheme #1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cacraigucar
requested changes
Mar 3, 2025
| @@ -2821,6 +2821,7 @@ | |||
| <zmconv_tau > 3600.0 </zmconv_tau> | |||
|
|
|||
| <zmconv_parcel_pbl > .false. </zmconv_parcel_pbl> | |||
| <zmconv_parcel_hscale phys="cam7" > 0.5 </zmconv_parcel_hscale> | |||
There was a problem hiding this comment.
What happens if phys is not cam7? The old logic had this being assigned for every run, so I would suggest removing the phys="cam7"
There was a problem hiding this comment.
If phys /= cam7 then zmconv_parcel_pbl = false and zmconv_parcel_hscale is never used. We could simply take out the phys="cam7" right?
There was a problem hiding this comment.
Yes, removing the phys="cam7" I believe is the proper fix. (What happens we go to cam8, this variable would have no value?)
There was a problem hiding this comment.
@cacraigucar I just removed the phys="cam7" option. Please let me know if you want anything else changed!
nusbaume
added a commit
to ESCOMP/atmospheric_physics
that referenced
this pull request
Mar 6, 2025
… scheme (#214) Originator(s): swrneale Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number): From issue [#203](#203) "Change the 'parcel_hscale' parameter in the ZM convection (zm_conv_intr.F90) to a namelist parameter" This PR is needed in parallel with ESCOMP/cam PR# [1266](ESCOMP/CAM#1266) List all namelist files that were added or changed: M schemes/zhang_mcfarlane/zm_conv_options_namelist.xml - Added new 'zmconv_parcel_hscale' namelist parameter for ZM scheme List all files eliminated and why: N/A List all files added and what they do: N/A List all existing files that have been modified, and describe the changes: (Helpful git command: `git diff --name-status development...<your_branch_name>`) M schemes/zhang_mcfarlane/zm_conv_options.F90 M schemes/zhang_mcfarlane/zm_conv_options.meta - Added new 'zmconv_parcel_hscale' namelist parameter for ZM scheme M schemes/zhang_mcfarlane/zm_convr.F90 M schemes/zhang_mcfarlane/zm_convr.meta - Replace hardcoded 'parcel_hscale' parameter with 'zmconv_parcel_hscale' namelist variable in core ZM scheme (zm_convr). List all automated tests that failed, as well as an explanation for why they weren't fixed: Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc? No If yes to the above question, describe how this code was validated with the new/modified features: --------- Co-authored-by: Jesse Nusbaumer <[email protected]>
cacraigucar
changed the title
…amelist defaults check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement parcel_hscale parameter that is hard coded in the ZM scheme as the namelist parameter zmconv_parcel_hscale. Provide the default value same as that which is currently hard coded (=0.5) so that changes should be bfb.