Bring in new atmospheric_physics tag and use CCPPized shortwave interfaces #1372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nusbaume
requested changes
Sep 17, 2025
There was a problem hiding this comment.
Thanks for bringing these changes into CAM @peverwhee! I just had a few small requests.
Comment on lines
+892
to
+894
| real(r8) :: cld_tau(nswbands,state%ncol,pver) ! Cloud absorption optics depth (sw) | ||
| real(r8) :: snow_tau(nswbands,state%ncol,pver) ! Snow absorption optics depth (sw) | ||
| real(r8) :: grau_tau(nswbands,state%ncol,pver) ! Graupel absorption optics depth (sw) |
There was a problem hiding this comment.
I might change the comments here slightly:
Suggested change
| real(r8) :: cld_tau(nswbands,state%ncol,pver) ! Cloud absorption optics depth (sw) | |
| real(r8) :: snow_tau(nswbands,state%ncol,pver) ! Snow absorption optics depth (sw) | |
| real(r8) :: grau_tau(nswbands,state%ncol,pver) ! Graupel absorption optics depth (sw) | |
| real(r8) :: cld_tau(nswbands,state%ncol,pver) ! Cloud absorption optical depth (sw) | |
| real(r8) :: snow_tau(nswbands,state%ncol,pver) ! Snow absorption optical depth (sw) | |
| real(r8) :: grau_tau(nswbands,state%ncol,pver) ! Graupel absorption optical depth (sw) |
Comment on lines
+1149
to
+1157
| dei_idx = pbuf_get_index('DEI',errcode=err) | ||
| mu_idx = pbuf_get_index('MU',errcode=err) | ||
| lambda_idx = pbuf_get_index('LAMBDAC',errcode=err) | ||
| iciwp_idx = pbuf_get_index('ICIWP',errcode=err) | ||
| iclwp_idx = pbuf_get_index('ICLWP',errcode=err) | ||
| des_idx = pbuf_get_index('DES',errcode=err) | ||
| icswp_idx = pbuf_get_index('ICSWP',errcode=err) | ||
| icgrauwp_idx = pbuf_get_index('ICGRAUWP',errcode=err) ! Available when using MG3 | ||
| degrau_idx = pbuf_get_index('DEGRAU',errcode=err) ! Available when using MG3 |
There was a problem hiding this comment.
Are all of these variables optional (i.e. need the errcode=err output)? If not then I might only pass out the errcode for quantities that are truly optional (with maybe a comment in the code here explicitly stating that they are optional).
Comment on lines
+1220
to
+1222
| call rrtmgp_sw_mcica_subcol_gen_run(dosw, kdist_sw, nswbands, nswgpts, nday, nlay, & | ||
| pver, tiny, idxday, ktopcam, ktoprad, cldfprime, c_cld_tau, & | ||
| c_cld_tau_w, c_cld_tau_w_g, cloud_sw, pmid_day(:ncol,:), errmsg, errflg) |
There was a problem hiding this comment.
Should we check errflg here?
Suggested change
| call rrtmgp_sw_mcica_subcol_gen_run(dosw, kdist_sw, nswbands, nswgpts, nday, nlay, & | |
| pver, tiny, idxday, ktopcam, ktoprad, cldfprime, c_cld_tau, & | |
| c_cld_tau_w, c_cld_tau_w_g, cloud_sw, pmid_day(:ncol,:), errmsg, errflg) | |
| call rrtmgp_sw_mcica_subcol_gen_run(dosw, kdist_sw, nswbands, nswgpts, nday, nlay, & | |
| pver, tiny, idxday, ktopcam, ktoprad, cldfprime, c_cld_tau, & | |
| c_cld_tau_w, c_cld_tau_w_g, cloud_sw, pmid_day(:ncol,:), errmsg, errflg) | |
| if (errflg /= 0) then | |
| call endrun(sub//': '//errmsg) | |
| end if |
| @@ -10,6 +10,7 @@ module rrtmgp_inputs_cam | |||
|
|
|||
| use shr_kind_mod, only: r8=>shr_kind_r8 | |||
| use ppgrid, only: pcols, pver, pverp | |||
| use cam_logfile, only: iulog | |||
There was a problem hiding this comment.
Total nit-pick, but maybe line up the only: with the other two above?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
configureto match the new locationaddresses #1192