-
Notifications
You must be signed in to change notification settings - Fork 344
Fix plumber2_surf_wrapper #3264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix plumber2_surf_wrapper #3264
Conversation
ekluzek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samsrabin and I went over this. And this is great work and I'm glad to see it come in. It fixes problems, but also makes the code more robust, with better error handling, AND it adds good testing for all this. So this will save the project time downstream.
I added a few comments/questions here that @samsrabin will decide on. I'm happy to approve it and have it come in shortly.
722504e to
63d61f4
Compare
- Replace NAT_PFT=15 with MAX_NAT_PFT=14 - Replace NUM_PFT=17 with MAX_PFT_GENERICCROPS=16 - Rename MAX_PFT to MAX_PFT_MANAGEDCROPS
Description of changes
--lon-type 180insubset_datacommand to avoid ambiguity.--overwriteoption.--plumber2-sites-csvoption to specify CSV file path.subset_datafailure.Specific notes
Contributors other than yourself, if any: None
CTSM Issues Fixed: Resolves #3262
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? No
Testing performed, if any: As of c325805:
761bb47) aren't affected.clm_pymodssuite:/glade/derecho/scratch/samrabin/tests_0620-185305de/