Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kessler_test Test SDF for FPHYStest to split off from FKESSLER test #204

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

jimmielin
Copy link
Member

Originator(s): jimmielin

Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number):

The FPHYStest test for Kessler in SIMA right now uses the same suite_kessler.xml as FKESSLER, which means it includes physics_after_coupler and other check_energy schemes we do not want to include in the FPHYStest test which should only be testing kessler_tend.

This PR includes a new suite_kessler_test.xml that removes all the other schemes from the SDF and keeps only what we want to test, and consistent with how the snapshots are taken in CAM:

      if (trim(cam_take_snapshot_before) == "kessler_tend") then
         call cam_snapshot_all_outfld(cam_snapshot_before_num, state, tend, cam_in, cam_out, pbuf)
      end if

      call kessler_tend(state, ptend, ztodt, pbuf)
      if ( (trim(cam_take_snapshot_after) == "kessler_tend") .and.            &
           (trim(cam_take_snapshot_before) == trim(cam_take_snapshot_after))) then
         call cam_snapshot_ptend_outfld(ptend, lchnk)
      end if
      call physics_update(state, ptend, ztodt, tend)

      if (trim(cam_take_snapshot_after) == "kessler_tend") then
         call cam_snapshot_all_outfld(cam_snapshot_after_num, state, tend, cam_in, cam_out, pbuf)
      end if

List all namelist files that were added or changed: N/A

List all files eliminated and why: N/A

List all files added and what they do:

A       test/test_suites/suite_kessler_test.xml
  - new kessler_test suite

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)
N/A

List all automated tests that failed, as well as an explanation for why they weren't fixed:
N/A

Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc?
Yes for FPHYStest kessler test

If yes to the above question, describe how this code was validated with the new/modified features:
BFB when using this suite

@jimmielin jimmielin added the enhancement New feature or request label Feb 14, 2025
@jimmielin jimmielin self-assigned this Feb 14, 2025
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jimmielin!

Copy link
Collaborator

@peverwhee peverwhee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@jimmielin jimmielin merged commit 252b500 into ESCOMP:development Feb 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Tag
Development

Successfully merging this pull request may close these issues.

3 participants