Make build and configure simpler #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I've tested with spack and [email protected], [email protected], [email protected] and [email protected] - all built correctly. |
jedwards4b
approved these changes
Mar 20, 2025
mahf708
reviewed
Mar 21, 2025
| AC_ARG_VAR(AR,Archive Command) | ||
| if test -z "$AR"; then | ||
| AR=ar | ||
| AR="ar cruv" |
Contributor
There was a problem hiding this comment.
@rljacob any specific reason for this with the "cruv?)
Contributor
There was a problem hiding this comment.
never mind, that's how it used to be
Contributor
|
@rljacob this PR broke the conda-forge builds. See here conda-forge/mpi_serial-feedstock#12 (comment). Any guess what may have caused that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore the configure system to its state in 1a84d6f (Dec 24) which was before the big autoconf redo of c9b6cdc (Dec 27). Cleaner and simpler build.
Fixes #35