Skip to content

Add call to super() on log_addition, log_change and log_deletion #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add call to super() on log_addition, log_change and log_deletion #281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions ESSArch_Core/auth/admin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,12 +127,15 @@ def has_module_permission(self, request):
return request.user.has_module_perms('auth')

def log_addition(self, request, object, message):
super().log_addition(request, object, message)
logger.info(f"User '{request.user}' attempts to add user '{object}' with msg: '{message}'.")

def log_change(self, request, object, message):
super().log_change(request, object, message)
logger.info(f"User '{request.user}' attempts to change the user '{object}' with msg: '{message}'.")

def log_deletion(self, request, object, message):
super().log_deletion(request, object, message)
logger.info(f"User '{request.user}' attempts to delete the user '{object}' with msg: '{message}'.")


Expand Down Expand Up @@ -200,12 +203,15 @@ def has_module_permission(self, request):
return request.user.has_module_perms('auth')

def log_addition(self, request, object, message):
super().log_addition(request, object, message)
logger.info(f"User '{request.user}' attempts to add group '{object}' with msg: '{message}'.")

def log_change(self, request, object, message):
super().log_change(request, object, message)
logger.info(f"User '{request.user}' attempts to change the group '{object}' with msg: '{message}'.")

def log_deletion(self, request, object, message):
super().log_deletion(request, object, message)
logger.info(f"User '{request.user}' attempts to delete the group '{object}' with msg: '{message}'.")


Expand All @@ -223,37 +229,46 @@ def has_module_permission(self, request):
return request.user.has_module_perms('groups_manager')

def log_addition(self, request, object, message):
super().log_addition(request, object, message)
logger.info(f"User '{request.user}' attempts to create new group type '{object}' with msg: '{message}'.")

def log_change(self, request, object, message):
super().log_change(request, object, message)
logger.info(f"User '{request.user}' attempts to change the group type '{object}' with msg: '{message}'.")

def log_deletion(self, request, object, message):
super().log_deletion(request, object, message)
logger.info(f"User '{request.user}' attempts to delete the group type '{object}' with msg: '{message}'.")


class GroupMemberRoleAdmin(admin.ModelAdmin):
filter_horizontal = ['permissions']

def log_addition(self, request, object, message):
super().log_addition(request, object, message)
logger.info(f"User '{request.user}' attempts to create role '{object}' with msg: '{message}'.")

def log_change(self, request, object, message):
super().log_change(request, object, message)
logger.info(f"User '{request.user}' attempts to change the role '{object}' with msg: '{message}'.")

def log_deletion(self, request, object, message):
super().log_deletion(request, object, message)
logger.info(f"User '{request.user}' attempts to delete the role '{object}' with msg: '{message}'.")


class ProxyPermissionAdmin(admin.ModelAdmin):

def log_addition(self, request, object, message):
super().log_addition(request, object, message)
logger.info(f"User '{request.user}' attempts to create permission '{object.name}' with msg: '{message}'.")

def log_change(self, request, object, message):
super().log_change(request, object, message)
logger.info(f"User '{request.user}' attempts to change the permission '{object.name}' with msg: '{message}'.")

def log_deletion(self, request, object, message):
super().log_deletion(request, object, message)
logger.info(f"User '{request.user}' attempts to delete the permission '{object.name}' with msg: '{message}'.")


Expand Down