Enhance AbsoluteDate and AbsoluteDateArray classes #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to use class method in state module. Refine comments for ICRF_EC in ReferenceFrame.
- Implement __repr__ for string representation. - Add __len__ , __getitem__, __eq__ methods to AbsoluteDateArray
…merging with the main branch
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances the AbsoluteDate and AbsoluteDateArray classes by adding arithmetic and representation operations and expanding functionality in associated state classes.
- Added the add operator and repr for AbsoluteDate.
- Implemented len, getitem, and eq (with repr) for AbsoluteDateArray.
- Updated factory methods (from_dict) in state classes to classmethods.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_time.py | Added tests for the new arithmetic and array operations in AbsoluteDate classes. |
| eosimutils/time.py | Implemented add and repr for AbsoluteDate and added array methods to AbsoluteDateArray. |
| eosimutils/state.py | Converted from_dict methods to class methods for improved inheritance support. |
| eosimutils/base.py | Updated inline comments for clarity in reference frame naming. |
ryanketzner
requested changes
Apr 28, 2025
…ctory and related tests. Other minor revisions,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__add__operator for AbsoluteDate__len__,__getitem__,__eq__methods to AbsoluteDateArray__repr__for string representation.