-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Re-record JSON responses for docs #120
Conversation
nwithan8
commented
Jan 19, 2024
•
edited
Loading
edited
- Most JSON responses have not changed outside of timestamps.
- Some have extra data entries (previously one or two records, now three or four).
- Some deprecated functionality (carbon offset, batch create+buy) have been removed.
- Added Python tool used to generate these response snippets + improved documentation and Makefile steps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like these regenerated using the correct user ID for the responses please, could be some weird artifacts mixed in if not (see internal diff for more details on that)
- gitignore auto-generated response files to avoid bloat
- Update README for better tool documentation - Fix JSON response tool unit tests
- Fix JSON response snippet tool Makefile - Lint JSON response snippets
I have addressed your feedback and re-recorded all the cassettes with the proper API keys, did result in a lot less diffs. I've also added the Python tool we use to generate these snippets into the |