-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use New Client Library Syntax for Guide Snippets #132
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix Goland import - Fix Error Guide examples in Java, .NET and Go
nwithan8
force-pushed
the
guides_new_syntax
branch
from
June 4, 2024 20:46
cd5d9e3
to
99cd215
Compare
- Fix .NET client initialization - Fix Go imports
Justintime50
changed the title
Guides new syntax
Use New Client Library Syntax for Guide Snippets
Jun 4, 2024
nwithan8
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was reviewing as I was referencing your work for my own contributions, LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates all our
guides
code snippets to use the current client library syntax. We had previously updated thedocs
but missed theguides
.This also removes a bunch of guide snippets that are no longer used on our docs (this is due to us reusing where possible the docs snippets on our guides to cut down on maintenance). If they've been removed, they are still accessible in the docs section.
Closes #124