Add The Qt Company's family of Qt extensions #856
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peat-psuwit
force-pushed
the
theqtcompany
branch
from
f190790 to
d3ed8a4
Compare
These extensions all live in a single repository. Most extensions are relatively straight-forward to build (non-extension-pack ones require building common library first). However, qt-core comes with a binary written in Go, which requires us to use custom commands to facilitate building it using GoReleaser. Build commands have handling for difference between the currently- published version and the current Git tip, in anticipation that the Git tip will eventually be released. GitHub workflows are modified to ensure Go environment is available. Extensions are dual-licensed between Qt's commercial license and LGPL 3.0 only. The issue which request publishing on Open-VSX [1] gets some interest from upstream, but does not have any update since September 2024. [1]: https://bugreports.qt.io/browse/VSCODEEXT-96 Signed-off-by: Ratchanan Srirattanamet <[email protected]>
peat-psuwit
force-pushed
the
theqtcompany
branch
from
d3ed8a4 to
833558c
Compare
|
Note: I've actually add a re-ping comment to the aforementioned upstream issue. My intention is if there's no response from upstream by Thursday (a week after the comment), I would proceed to un-draft the PR. |
|
Upstream has shown an interest in uploading extensions to Open-VSX. I'll see if this will eventually happen, and if so will close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This add The Qt Company's family of Qt extensions. PR These extensions all live in a single repository. Most extensions are relatively straight-forward to build (non-extension-pack ones require building common library first). However, qt-core comes with a binary written in Go, which requires us to use custom commands to facilitate building it using GoReleaser.
Build commands have handling for difference between the currently- published version and the current Git tip, in anticipation that the Git tip will eventually be released.
GitHub workflows are modified to ensure Go environment is available.
Extensions are dual-licensed between Qt's commercial license and LGPL 3.0 only. The issue which request publishing on Open-VSX [1] gets some interest from upstream, but does not have any update since September 2024.
[1]: https://bugreports.qt.io/browse/VSCODEEXT-96