Wallet settings #706
Open
Wallet settings #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The items in the list are already known to need these changes, so there is no need to double-check.
This lets us control settings on a per-wallet basis, instead of per-chain (which is that the old userSettings property handles).
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| enabledTokenIds?: string[] | ||
| fiatCurrencyCode?: string | ||
| name?: string | ||
| walletSettings?: JsonObject |
There was a problem hiding this comment.
Wallet settings silently dropped during non-memory wallet creation
High Severity
walletSettings was added to EdgeCreateCurrencyWalletOptions and is correctly handled for memory wallets in memory-wallet.ts, but finishWalletCreation in keys.ts does not destructure or use walletSettings from opts. When a non-memory wallet is created via createCurrencyWallet or createCurrencyWallets with walletSettings, the settings are silently ignored and never persisted to disk via wallet.changeWalletSettings().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
noneNote
Medium Risk
Touches core wallet initialization, persistence, and engine option plumbing; mis-wiring could cause engines to start with incorrect settings or fail when plugins don’t expect the new required
userSettings/walletSettingsfields.Overview
Adds wallet-scoped settings plumbing end-to-end:
EdgeCurrencyWalletnow exposeswalletSettingspluschangeWalletSettings, and engines can optionally implementchangeWalletSettingsand receive initialwalletSettingsviaEdgeCurrencyEngineOptions.Wallet settings are persisted per wallet to
WalletSettings.json, loaded on wallet startup and on storage sync changes, stored in redux via new actions/reducer state, and passed into engine creation (includingmakeMemoryWallet). Also tightens several type surfaces by making plugin/swapuserSettingsnon-optional and adding acurrencyInfo.hasWalletSettingsfeature flag gate.Written by Cursor Bugbot for commit 09976ac. This will update automatically on new commits. Configure here.