Implement react-native-reorderable-list #5351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
approved these changes
Nov 8, 2024
Contributor
|
Was this tested on iOS? We should definitely do that before merging. |
Jon-edge
force-pushed
the
jon/fix/wallet-reorder
branch
2 times, most recently
from
698fcfb to
ab84ba9
Compare
swansontec
requested changes
Nov 11, 2024
Contributor
swansontec
left a comment
swansontec
left a comment
There was a problem hiding this comment.
Small changes needed, but this looks good.
jestSetup.js
Outdated
| jest.mock('react-native-reorderable-list', () => ({ | ||
| ...jest.requireActual('react-native-reorderable-list'), | ||
| useReorderableDrag: () => jest.fn(), | ||
| })) |
Contributor
There was a problem hiding this comment.
Missing newline in file.
| return handler | ||
| } | ||
|
|
||
| export const useSceneScrollWorkletHandler = () => { |
Contributor
There was a problem hiding this comment.
Please add a comment to this to explain why this is different than the one above.
| account.changeWalletStates(keyStates).catch(error => showError(error)) | ||
| }) | ||
|
|
||
| const keyExtractor = (item: string) => item |
Contributor
There was a problem hiding this comment.
I think this needs a useHandler or useCallback as well.
Collaborator
Author
There was a problem hiding this comment.
Using a useHandler here somehow broke the feature, not sure why...
Is this ok to leave with just a comment?
Collaborator
Author
There was a problem hiding this comment.
Figured it out, needed to use useCallback
Jon-edge
force-pushed
the
jon/fix/wallet-reorder
branch
from
ab84ba9 to
4a94fb3
Compare
swansontec
approved these changes
Nov 11, 2024
Jon-edge
force-pushed
the
jon/fix/wallet-reorder
branch
from
4a94fb3 to
a23c94d
Compare
Jon-edge
force-pushed
the
jon/fix/wallet-reorder
branch
2 times, most recently
from
06a7961 to
22e402b
Compare
Jon-edge
changed the title
Jon-edge
force-pushed
the
jon/fix/wallet-reorder
branch
from
22e402b to
db60fb2
Compare
Jon-edge
force-pushed
the
jon/fix/wallet-reorder
branch
from
db60fb2 to
bc68c9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
May need to go with the new library route.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: