Fix incorrect rounded corners on iOS #5357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samholmes
requested changes
Nov 13, 2024
Contributor
There was a problem hiding this comment.
Change the commit message:
Apply rounded corners only to NotificationCard
Rounded corners were applied to all implementations of BlurBackground
which caused the header and footer to have rounded corners. This was
never apart of the design for the header and footer and accidentally
slipped through as a bug because it never manifest itself in Android;
it only appeared in iOS. Nonetheless, this fix will remove the rounded
corner styles in the BlurBackground component by default, and provide a
parameter to enable it for NotificationCard.
Jon-edge
force-pushed
the
jon/fix/ios-rounded-menu-title
branch
5 times, most recently
from
4124210 to
1cbbce3
Compare
samholmes
requested changes
Nov 13, 2024
Contributor
samholmes
left a comment
samholmes
left a comment
There was a problem hiding this comment.
Commit message comment still applies (or something like it)
| export const BlurBackground = (props: { | ||
| /** If the parent requires rounded corners, this prop must be set true in | ||
| * order to ensure parity between iOS/Android */ | ||
| noRoundedCorners?: boolean |
Contributor
There was a problem hiding this comment.
Let's go with rounded as an option instead of rounded by default. Or add a RoundedBlurBackground element which can be used in rounded components.
Jon-edge
force-pushed
the
jon/fix/ios-rounded-menu-title
branch
from
1cbbce3 to
addcbe3
Compare
samholmes
approved these changes
Nov 13, 2024
Collaborator
Author
|
If that assumption fails in the future, then we just need to update the component's comment. I specifically made a generalized component name instead of naming Regarding specific radius - that's a theme thing. I would really dislike it if we used varying radii across the app. |
Regressed as a result of the latest `NotificationCard` updates (66b4bdd) The above commit made changes to support rounded borders for the `NotificationCard` by changing `BlurBackground` for all callers. The callers responsible for the header/footer also use `BlurBackground,` but require a non-rounded variant. Due to the parity difference in iOS and Android blur styling, this regression was only observable on iOS.
Jon-edge
force-pushed
the
jon/fix/ios-rounded-menu-title
branch
from
8cd2d90 to
a16c11d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regressed as a result of changes to support rounded blur corners for iOS in the latest
NotificationCardupdates (66b4bdd).CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: