Skip to content

Sam/mo-venmo-pal #5366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samholmes merged 2 commits into from
Dec 2, 2024
Merged

Sam/mo-venmo-pal #5366

samholmes merged 2 commits into from
Dec 2, 2024

Conversation

@samholmes
Copy link
Contributor

@samholmes samholmes commented Nov 19, 2024 •
edited
Loading

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

paullinator
paullinator requested changes Nov 21, 2024
View reviewed changes
src/constants/plugins/sellPluginList.json Outdated
"description": "Fee: ~5%\nSettlement: 5 min - 24 hours",
"forCountries": [
"AE", "AR", "AT", "AU", "BE", "BR", "CA", "CH", "CL", "CO",
"CZ", "DE", "DK", "EG", "ES", "FI", "FR", "GH", "GR", "HK",
Copy link
Member

@paullinator paullinator Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also only US

paullinator
paullinator requested changes Nov 23, 2024
View reviewed changes
src/constants/plugins/buyPluginList.json Outdated
"title": "Venmo",
"description": "Fee: ~5%\nSettlement: 5 min - 24 hours",
"forCountries": [
"AE", "AR", "AT", "AU", "BE", "BR", "CA", "CH", "CL", "CO",
Copy link
Member

@paullinator paullinator Nov 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should only be US

@samholmes samholmes enabled auto-merge November 27, 2024 22:28
@samholmes samholmes merged commit 0106690 into develop Dec 2, 2024
2 checks passed
@samholmes samholmes deleted the sam/mo-venmo-pal branch December 2, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swansontec swansontec swansontec approved these changes

@paullinator paullinator paullinator approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@samholmes @swansontec @paullinator