Use chain icon for staking cards #5386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
approved these changes
Dec 4, 2024
Contributor
swansontec
left a comment
swansontec
left a comment
There was a problem hiding this comment.
I am approving this, because the only requested change should be a copy-paste.
Comment on lines
+88
to
+93
| const stakeAssetUris = stakeContractAddresses.map( | ||
| stakeContractAddress => getCurrencyIconUris(pluginId, stakeContractAddress ?? null, SPECIAL_CURRENCY_INFO[pluginId]?.chainIcon ?? false).symbolImage | ||
| ) | ||
| const rewardAssetUris = rewardContractAddresses.map( | ||
| rewardContractAddress => getCurrencyIconUris(pluginId, rewardContractAddress ?? null, SPECIAL_CURRENCY_INFO[pluginId]?.chainIcon ?? false).symbolImage | ||
| ) |
Contributor
There was a problem hiding this comment.
This is pretty gnarly logic to keep two copies. Can we make a helper function?
const getAssetChainIcon = (contractAddress: string) =>
getCurrencyIconUris(
pluginId,
contractAddress ?? null,
// We want the chain icon if it makes sense:
SPECIAL_CURRENCY_INFO[pluginId]?.chainIcon ?? false
).symbolImage
const stakeAssetUris = stakeContractAddresses.map(getAssetChainIcon)
const rewardAssetUris = rewardContractAddresses.map(getAssetChainIcon)
Contributor
Author
There was a problem hiding this comment.
Sure, will change it
peachbits
force-pushed
the
matthew/earn-scene-icons
branch
from
8da318d to
7a16c5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: