Clean old archive directories on builds #5408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullinator
force-pushed
the
paul/cleanDirs
branch
from
66777f0 to
b73bf0a
Compare
samholmes
approved these changes
Dec 19, 2024
scripts/cleanDirectories.ts
Outdated
| } | ||
|
|
||
| // Pure function: filters old directories | ||
| export const filterOldDirs = (dirNames: string[], cutoffDate: Date): string[] => |
Contributor
There was a problem hiding this comment.
Suggest change name to filterForOldDirs (filtering implies removing, so adding "for" into the name may help to fix that).
Helps prevent disk full errors
paullinator
force-pushed
the
paul/cleanDirs
branch
from
b73bf0a to
c776c3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps prevent disk full errors
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: