Disallow deprecated wallets from parsing links #5412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
approved these changes
Dec 25, 2024
src/actions/DeepLinkingActions.tsx
Outdated
| // Try to parse with all wallets | ||
| for (const wallet of Object.values(currencyWallets)) { | ||
| // Ignore disabled wallets: | ||
| if (SPECIAL_CURRENCY_INFO[wallet.currencyInfo.pluginId].keysOnlyMode) return |
Contributor
There was a problem hiding this comment.
Since keysOnlyMode can be undefined, we should do const { keysOnlyMode = false } = SPECIAL_CURRENCY_INFO, and then you can do if (keysOnlyMode) on the next line. That makes the default value explicit.
Jon-edge
force-pushed
the
jon/fix/deprecated-scan
branch
from
2cf8164 to
a4208e2
Compare
Jon-edge
force-pushed
the
jon/fix/deprecated-scan
branch
from
a4208e2 to
ea4a5d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: