Jon/fix/ios-carousel #5548
Open
Jon/fix/ios-carousel #5548
+33
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
approved these changes
Apr 25, 2025
Comment on lines
49
to
53
| const tempData = [...dataLocal] | ||
| setDataLocal([]) | ||
| setTimeout(() => { | ||
| setDataLocal(tempData) | ||
| }, 50) |
There was a problem hiding this comment.
What about:
setDataLocal([])
setTimeout(() => setDataLocal(data), 50)This would let the hook's dependencies actually match the deps array, and would also get rid of the tempData variable.
Reinstate rendering hack. `dataLocal` as a dependency was causing an infinite loop for iOS repeatedly clearing the data every 500ms. The rendering hacks need only trigger once on mount. Delay also reduced to be less perceptible.
Jon-edge
force-pushed
the
jon/fix/ios-carousel
branch
from
ad640d7 to
1339099
Compare
swansontec
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous change that attempted to fix flickering of the promo card,
dataLocalas a dependency was causing an infinite loop for iOS repeatedly clearing the data every 500ms.The rendering hacks was incorrectly verified as no longer being necessary. and removed.
The hacks are still necessary, but need only trigger once on mount.
Delay also reduced to be less perceptible.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: