Skip to content

Conversation

@samholmes
Copy link
Contributor

@samholmes samholmes commented Oct 17, 2025

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Note

Reworks ramp amount handling to a discriminated exchangeAmount union, extracts region selection into RampRegionSelect, updates form/disable logic and max flow, and aligns all ramp plugins with the new API.

  • Frontend (RampCreateScene):
    • Replace userInput/isMaxAmount with discriminated exchangeAmount ({ amount } | { max: true } | { empty: true }).
    • Introduce AmountTypeSupport as onlyCrypto/onlyFiat and update all disable/guard logic and Next button conditions.
    • Rework display amount derivation to compute conversions inline; remove helper converters.
    • Revise max-flow handling (selection, auto-navigation, persistence) using exchangeAmount.max.
    • Compute input disabled states based on exchangeAmount.max, quote availability, and amount-type support.
    • Extract region selection UI to new component components/scenes/RampCreateScene/RampRegionSelect and use it when needed.
  • Types:
    • Add RampExchangeAmount type and change RampQuoteRequest.exchangeAmount to use it.
  • Plugins (banxa, bity, moonpay, paybis, revolut, simplex):
    • Update quote handlers to read exchangeAmount via 'max' in/'amount' in checks.
  • UI Cleanup:
    • Simplify region selection rendering; remove in-scene steps/flag logic in favor of RampRegionSelect.

Written by Cursor Bugbot for commit 5fc1483. This will update automatically on new commits. Configure here.


cursor[bot]

This comment was marked as outdated.

@samholmes samholmes force-pushed the sam/fix-max-unsupported branch from 8d9e3dd to 3990151 Compare October 17, 2025 20:00
cursor[bot]

This comment was marked as outdated.

@samholmes samholmes force-pushed the sam/fix-max-unsupported branch from 3990151 to 58d3224 Compare October 21, 2025 21:08
@samholmes samholmes force-pushed the sam/fix-max-unsupported branch from 58d3224 to 5fc1483 Compare October 21, 2025 21:11
@samholmes samholmes merged commit 137b4bb into develop Oct 21, 2025
3 checks passed
@samholmes samholmes deleted the sam/fix-max-unsupported branch October 21, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants