Skip to content

Conversation

samholmes
Copy link
Contributor

@samholmes samholmes commented Oct 20, 2025

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Note

Switches to getAddresses and prefers segwit address (with fallback) for Banxa buy/sell wallet, refund, and confirmation source addresses.

  • Banxa ramp plugin (src/plugins/ramps/banxa/banxaRampPlugin.ts):
    • Address selection:
      • Replace getReceiveAddress with getAddresses and prefer segwitAddress when available; fallback to default public address; throw if missing.
    • Usage updates:
      • Use selected address for wallet_address/refund_address in order creation and source_address in order confirmation.

Written by Cursor Bugbot for commit d1f06e0. This will update automatically on new commits. Configure here.


@samholmes samholmes force-pushed the sam/ramps-getAddresses branch from 0c0f45f to 238fd9f Compare October 20, 2025 23:12
This is a TODO item that was missed. The original implementation used
the correct getAddresses function, so we're copying that implementation
over to the ramps plugin.
@samholmes samholmes force-pushed the sam/ramps-getAddresses branch from 238fd9f to d1f06e0 Compare October 21, 2025 22:09
@samholmes samholmes enabled auto-merge October 21, 2025 22:09
@samholmes samholmes merged commit 12c59c0 into develop Oct 21, 2025
3 checks passed
@samholmes samholmes deleted the sam/ramps-getAddresses branch October 21, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants