Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/light-comics-rest.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@effect/platform": minor
---

Support `URL` in `HttpClientRequest.prependUrl` parameter
4 changes: 2 additions & 2 deletions packages/platform/src/HttpClientRequest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -211,8 +211,8 @@ export const setUrl: {
* @category combinators
*/
export const prependUrl: {
(path: string): (self: HttpClientRequest) => HttpClientRequest
(self: HttpClientRequest, path: string): HttpClientRequest
(path: string | URL): (self: HttpClientRequest) => HttpClientRequest
(self: HttpClientRequest, path: string | URL): HttpClientRequest
} = internal.prependUrl

/**
Expand Down
15 changes: 9 additions & 6 deletions packages/platform/src/internal/httpClientRequest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -264,19 +264,22 @@ export const appendUrl = dual<

/** @internal */
export const prependUrl = dual<
(path: string) => (self: ClientRequest.HttpClientRequest) => ClientRequest.HttpClientRequest,
(self: ClientRequest.HttpClientRequest, path: string) => ClientRequest.HttpClientRequest
>(2, (self, url) =>
makeInternal(
(path: string | URL) => (self: ClientRequest.HttpClientRequest) => ClientRequest.HttpClientRequest,
(self: ClientRequest.HttpClientRequest, path: string | URL) => ClientRequest.HttpClientRequest
>(2, (self, url) => {
const clone = typeof url === "string" ? url : url.toString()

return makeInternal(
self.method,
url.endsWith("/") && self.url.startsWith("/") ?
clone.endsWith("/") && self.url.startsWith("/") ?
url + self.url.slice(1) :
url + self.url,
self.urlParams,
self.hash,
self.headers,
self.body
))
)
})

/** @internal */
export const updateUrl = dual<
Expand Down
19 changes: 19 additions & 0 deletions packages/platform/test/HttpClientRequest.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import * as HttpClientRequest from "@effect/platform/HttpClientRequest"
import { describe, it } from "@effect/vitest"
import { deepStrictEqual } from "@effect/vitest/utils"

describe("HttpClientRequest", () => {
const intialRequest = HttpClientRequest.make("GET")("/test")

it("prependUrl with a string", () => {
const result = intialRequest.pipe(HttpClientRequest.prependUrl("https://example.com"))

deepStrictEqual(result.url, "https://example.com/test")
})

it("prependUrl with an URL instance", () => {
const result = intialRequest.pipe(HttpClientRequest.prependUrl(new URL("https://example.com")))

deepStrictEqual(result.url, "https://example.com/test")
})
})