Update window/exe icons, show Open File dialog on startup#38
Open
NoahDomingues wants to merge 1 commit intoEgoEngineModding:masterfrom
Open
Update window/exe icons, show Open File dialog on startup#38NoahDomingues wants to merge 1 commit intoEgoEngineModding:masterfrom
NoahDomingues wants to merge 1 commit intoEgoEngineModding:masterfrom
Conversation
Collaborator
Contributor
Author
|
Hello! Thank you for the feedback. I'm also a graphic designer (when I'm not modding xD), I could probably come up with an icon template if I understand what you're looking for. If you'd like I can message you on Discord if it's easier to converse N =) |
ptasev
reviewed
Aug 7, 2025
Collaborator
There was a problem hiding this comment.
I'm no expert in WinForms, but this is how I've done icon setting in past apps. I think the way that it's done currently will result in the app size increasing since the icon is embedded in the resources multiple times.
- Put the ico file in the
Resourcesdirectory - Reference the icon in the csproj file
- Using VS add the icon.ico in the
Resources/Resources.resx. It should generate this - In each form's constructor set icon to the instance in the resources
If someone reading this knows a better way, please let us know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Just a few tiny changes:
N =)