-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#1304624): Add e2e tests and add the service that lauches them i… #638
base: 2.0.x
Are you sure you want to change the base?
Conversation
294b242
to
0338679
Compare
9c8527e
to
42dda75
Compare
42dda75
to
afe847f
Compare
afe847f
to
a3ef1fb
Compare
Coverage report for commit: 985b9dc Summary - Lines: 87.31% | Methods: 84.17%
Backend Coverage of this branch |
a3ef1fb
to
c3690ed
Compare
1574e8a
to
f398382
Compare
02054c2
to
aa1fc8e
Compare
fe06fc5
to
2591b41
Compare
Frontend Coverage of this branch
Minimum allowed coverage is Generated by 🐒 cobertura-action against 985b9dc |
4b2470e
to
37d4de3
Compare
.github/workflows/ci.yml
Outdated
@@ -6,6 +6,7 @@ on: | |||
- master | |||
- '[1-9].[0-9]+.x' | |||
- 'feature-[a-z]+' | |||
- 'feat-1304624-tests-e2e-playwright' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ça me parait bizarre de faire une exception juste pour une branche spécifique.
Tu aurais du nommer ta branche feature-
ou alors ajouter une règle générique peut-être sur feat-[a-z]+
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
J'avais ajouté cette ligne pour vérifier que les tests E2E s'exécutaient correctement sur la CI de cette branche. Maintenant que c'est confirmé, je vais le retirer.
37d4de3
to
6c06658
Compare
6c06658
to
985b9dc
Compare
…n docker compose