Bookkeeper Dashboard

[evansmj]

This adds 4 new features:

bookkeeper/balancesheet
bookkeeper/satsflow
bookkeeper/volume
bookkeeper/terminal

and a /bookkeeper landing page

[evansmj]

Time granularity designs:

[evansmj]

Landing

[evansmj]

Balance Sheet

[evansmj]

Sats Flow

[evansmj]

Volume

[evansmj]

Terminal

[chrisguida]

Wow! Very impressive PR, thanks for putting this together @evansmj!

Just some quick comments and ideas for future improvement:

• The .js files should not be included, and the docs should tell the user to build the code first before running (or maybe npm install --omit dev and npm run start already do the build?)
• I love the terminal tab! It would be great if it could display an actual table instead of raw json
  • It would also be great if you could provide some useful examples, like select account, sum(credit_msat)/1000 - sum(debit_msat)/1000 from bkpr_income group by account;
• Relatedly to the above, it would be great if there were more grouping/filtering options in the satsflow and the balance sheet, to see exactly how much money flowed into and out of each account, not just the entire node.
• One thing people will want this for is calculating capital gains taxes on their Lightning nodes, so it would be neat to be able to see fiat values as well (though exporting to CSV and importing to tax software could solve this as well).

Anyway this PR is already super useful, @ShahanaFarooqui what needs to happen to get this merged? :)

[ShahanaFarooqui]

Anyway this PR is already super useful, @ShahanaFarooqui what needs to happen to get this merged? :)

Apologies for not having reviewed it yet. I was hoping to have done so by now, but I got caught up fixing CI issues caused by updates to Poetry and Ubuntu on GitHub Actions. Hopefully, I will be able to review it by the end of this week.

[evansmj]

Hey @ShahanaFarooqui, I noticed the apps/frontend/build folder has been previously committed to the repo. Is this on purpose? This means that if someone runs npm run start without knowing to first build the newer changes, they will not see the latest changes. That is what happened to @chrisguida.

[evansmj]

Thanks @chrisguida I added your suggestions as issues here and will get to them in a later update.

#81
#79
#80

Regarding the csv dump, for v2 I am planning to add functionality for the remaining bookkeeper commands:
bkpr-dumpincomecsv
bkpr-channelsapy
bkpr-editdescriptionbyoutpoint
bkpr-editdescriptionbypaymentid
bkpr-inspect