Assume option_channel_type #8389
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per BOLT recommendation lightning/bolts#1232, this means we will insist on this being available. For CLN, we added this in 0.12.0 (2022-08-23), though there were fixes as late as 24.02. Either way that's well outside our support window. Signed-off-by: Rusty Russell <[email protected]> Closes: ElementsProject#8152 Changelog-Changed: Protocol: We now insist that peers support `option_channel_type` (in CLN since 0.12.0 in late 2022, similar for other implementations).
Simplifies our logic somewhat. Signed-off-by: Rusty Russell <[email protected]>
This allows us to specify: l2.rpc.plugin_start(plugin_path, zeroconf_allow=l1.info['id']) Signed-off-by: Rusty Russell <[email protected]>
Signed-off-by: Rusty Russell <[email protected]>
Makes sure we don't break it! Signed-off-by: Rusty Russell <[email protected]>
Prior to it being compulsory, these daemons would need a default value. Now it's always required, it's clearer if it's always told. There's no "default_channel_type" now everyone has to specify channel_type either, so rename it to "desired_channel_type" and put it in lightningd specifically. Note that the channel_type can have options added: either option_scid_alias or option_zeroconf. This results in a slight behavior change: we will get type zeroconf even if we didn't ask for it, if they gave it to us. Signed-off-by: Rusty Russell <[email protected]> Changelog-Changed: JSON-RPC: fundchannel / fundchannel_start returned `channel_type` will include option_zeroconf if it was implied by a 0 minimum_depth, even if we didn't explicitly ask for a zero conf channel.
This was needed for v23.05 which would set opt_scid_alias even if we didn't. Now everyone handles it properly, we can simply set it unconditionally. Signed-off-by: Rusty Russell <[email protected]> Changelog-Removed: Protocol: backwards compatibility allowances for CLN before 23.08 which didn't handle option_scid_alias properly.
rustyrussell
force-pushed
the
guilt/assume-option_channel_type
branch
from
39d0294 to
6712737
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As referred to in lightning/bolts#1232 we make this a compulsory feature.
Cleans up a lot of code, including some workarounds for 23.05.