common: fix dangling memory allocation in daemon_conn_new_()
#8424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This memleak was unearthed by the new fuzz test in #8423 . |
morehouse
approved these changes
Jul 22, 2025
4 tasks
Changelog-Fixed: Use the correct context in `daemon_conn_new_()` by allocating `struct daemon_conn` with `ctx` instead of `NULL`. This ensures proper ownership and cleanup of `daemon_conn` objects, avoiding memory leaks.
rustyrussell
force-pushed
the
daemon_bug
branch
from
ea7b257 to
147f9ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog-Fixed: Use the correct context in
daemon_conn_new_()by allocatingstruct daemon_connwithctxinstead ofNULL.This ensures proper ownership and cleanup of
daemon_connobjects, avoiding memory leaks.Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:
CC: @morehouse