onion: add payload type tracking to route_step and onion_payload #8697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `onion_payload_type` enum and `type` field to track whether payloads are legacy v0 or modern TLV format. Move the `onion_payload_type` enum from `onion_encode.h` to `sphinx.h` and add a `type` field to both `route_step` and `onion_payload` structures. Previously, `onion_payload` had the `type` field declared but it was never set or used. The type is now set during onion processing in `process_onionpacket()` based on the payload format detected, then propagated to `onion_payload` in `onion_decode()`. This allows code to easily determine the payload format without re-parsing the raw payload. Changelog-None
erickcestari
force-pushed
the
track-onion-payload-type
branch
from
fd795d4 to
ea7a032
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
onion_payload_typeenum tosphinx.hand add type field to bothroute_stepandonion_payloadstructures. This allows code to easily determine whether it's dealing with legacy v0 or modern TLV payloads without re-parsing the raw payload.The type is set during onion processing in
process_onionpacket()based on the payload format detected, then propagated to onion_payload inonion_decode().Changelog-None