Fix bug with part_data_end and body_end not emitted #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least for a small text file containing just "This is a test."
Fix bug with part_data_end and body_end not emitted
me21
changed the title
|
I just realized this reverts iafonov@6b63ed9, so we may need another fix after that. |
Consider a file containing the following lines: ``` 11:38<CR><LF> 14:23<CR><LF> ``` where <CR> and <LF> are single bytes with values 13 and 10 respectively. The first two bytes on the next line after <CR><LF> is lost - the part data callback doesn't include them.
|
Added another commit which fixes two lost bytes in the beginning of the new line if the previous one ended with . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least for a small text file containing just "This is a test."