Release / 5.21.0 #4492
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| import { Typography, Button, Grid, Stack, Link } from '@mui/material'; | ||
| import { styled } from '@mui/material/styles'; | ||
| import { useModal } from '../modals/ModalContext'; | ||
| import { useEffect } from 'react'; | ||
| import CardanoCardImage from './CardanoCardImage.png'; | ||
| import LocalStorageApi from '../../../api/localStorage/index'; | ||
| import { useStrings } from '../../common/hooks/useStrings'; | ||
| import { CARDANO_CARD_URL } from '../../common/constants'; | ||
| import { useYoroiRemoteConfig } from '../../common/hooks/useYoroiRemoteConfig'; | ||
|
|
||
| let hasProcessedThisSession = false; | ||
|
|
||
| export const CardanoCardDialog = () => { | ||
| const strings = useStrings(); | ||
| const { openModal, closeModal } = useModal(); | ||
| const { data } = useYoroiRemoteConfig(); | ||
|
|
||
| useEffect(() => { | ||
| const checkModalState = async () => { | ||
| const localStorage = new LocalStorageApi(); | ||
| const appOpenedCount = await localStorage.getAppOpenedCount(); | ||
|
|
||
| if (!data?.popups?.cardanoCardAnnouncement?.display || hasProcessedThisSession) return; | ||
|
|
||
| // Mark as processed to prevent re-execution on data refetches and component remounts | ||
| hasProcessedThisSession = true; | ||
| if (appOpenedCount === undefined || appOpenedCount === null) { | ||
| localStorage.setAppOpenedCount('1'); | ||
| } else { | ||
| localStorage.setAppOpenedCount(String(Number(appOpenedCount) + 1)); | ||
| } | ||
|
|
||
| if (!appOpenedCount || appOpenedCount === '4') { | ||
| openModal({ | ||
| title: strings.cardanoCardTitle, | ||
| height: '550px', | ||
| width: '612px', | ||
| content: ( | ||
| <CardanoCardContent | ||
| onClose={() => { | ||
| closeModal(); | ||
| }} | ||
| /> | ||
| ), | ||
| modalId: 'cardanoCard', | ||
| onClose: () => { | ||
| closeModal(); | ||
| }, | ||
| }); | ||
| } | ||
| }; | ||
|
|
||
| checkModalState(); | ||
| }, [data]); | ||
|
|
||
| return null; | ||
| }; | ||
|
|
||
| const CardanoCardContent = ({ onClose }) => { | ||
| const strings = useStrings(); | ||
| return ( | ||
| <Stack> | ||
| <Stack direction="column" alignItems="center" justifyContent="center" pb="24px"> | ||
| <Stack my={48}> | ||
| <img src={CardanoCardImage} alt="Cardano Card Illustration" /> | ||
| </Stack> | ||
|
|
||
| <Typography variant="h5" color="ds.text_gray_medium" fontWeight={500} mb="8px"> | ||
| {strings.cardanoCardSubtitle} | ||
| </Typography> | ||
| <Typography variant="body1" color="ds.text_gray_medium" textAlign="center" mx="24px" sx={{ whiteSpace: 'pre' }}> | ||
| {strings.cardanoCard} | ||
| </Typography> | ||
| </Stack> | ||
|
|
||
| <Grid justifyContent="space-between" direction="column" style={{ marginTop: 18 }}> | ||
| <Link href={CARDANO_CARD_URL} target="_blank" rel="noopener noreferrer" onClick={onClose}> | ||
| <CustomButton variant="contained" color="primary"> | ||
| {strings.cardanoCardGetTheCard} | ||
| </CustomButton> | ||
| </Link> | ||
| </Grid> | ||
| </Stack> | ||
| ); | ||
| }; | ||
|
|
||
| const CustomButton = styled(Button)(() => ({ | ||
| width: '100%', | ||
| fontSize: '16px', | ||
| lineHeight: '22px', | ||
| })); | ||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing cleanup for async operations in useEffect
Medium Severity
The
useEffectruns an async function that performs localStorage operations and potentially callsopenModal, but lacks a cleanup function to handle component unmount. If the component unmounts ordatachanges while the async operation is in progress, it will continue executing and attempt to callopenModaland update the module-levelhasProcessedThisSessionvariable after unmount, potentially causing memory leaks and unexpected modal behavior.