Merged
Conversation
neilberkman
force-pushed
the
remove-has-redlines
branch
from
809930f to
863266f
Compare
Breaking: removes has_redlines?/1 and the PDF.has_redlines?/2 delegation. Bumps pdf_redlines dep to ~> 0.7.0.
neilberkman
force-pushed
the
remove-has-redlines
branch
from
863266f to
f438509
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
has_redlines?/1from the public API andPDF.has_redlines?/2delegationpdf_redlinesdep to~> 0.7.0, version to 0.6.0Changes
Callers should use
Redlines.extract/2and checkresult.changes == []. The pre-check was a heuristic that risked false negatives and doubled the PDF rendering cost when redlines were found.Depends on pdf_redlines 0.7.0 being published first.